Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.js plugin support #77

Closed
computmaxer opened this issue Aug 6, 2014 · 4 comments
Closed

System.js plugin support #77

computmaxer opened this issue Aug 6, 2014 · 4 comments

Comments

@computmaxer
Copy link

System.js has some plugins that allow it to load other types of files, such as CSS: https://github.com/systemjs/systemjs#plugins

I am able to jspm install a plugin, however it does not successfully load the plugin. In the case of the CSS plugin, it makes a request looking for /css.js instead of looking in /jspm_packages/github/systemjs/plugin-css/.

I'm guessing this is because System.js is loading the plugin itself implicitly after seeing an import like this: import "../css/bootstrap.css!";

Any thoughts on how to address this? I'd be happy to submit a PR if you have an idea @guybedford

@guybedford
Copy link
Member

How are you installing css?

Did you just do - jspm install css?

@computmaxer
Copy link
Author

Ah, no I was doing jspm install github:systemjs/plugin-css

It works now. Thanks!

@guybedford
Copy link
Member

Great. I may be changing the plugin names in future to be more indicative that they are plugins like jspm install css! instead.

I'll be sure to include any changes like this in the release notes.

@computmaxer
Copy link
Author

+1 to that idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants