Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection vulnerability? #163

Closed
trusktr opened this issue Oct 5, 2014 · 2 comments
Closed

Injection vulnerability? #163

trusktr opened this issue Oct 5, 2014 · 2 comments

Comments

@trusktr
Copy link

trusktr commented Oct 5, 2014

https://github.com/jspm/jspm-cli/blob/master/cli.js#L141

When the registry gets bigger, a an injection in a pull request could easily be missed.

@guybedford
Copy link
Member

Thanks for looking out for these things. The override here is taken from a commandline argument, so there is no injection risk. The reason I use eval is because I personally prefer not having to write double quotes around all properties when quickly testing out an override.

@trusktr
Copy link
Author

trusktr commented Oct 8, 2014

@guybedford Makes sense, and the config files are JSON format so they won't work if someone makes a PR with code in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants