Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use "opn" instead of "open" #36

Merged
merged 1 commit into from
Mar 14, 2019
Merged

use "opn" instead of "open" #36

merged 1 commit into from
Mar 14, 2019

Conversation

YunfengZhao915
Copy link
Contributor

No description provided.

@yindia
Copy link

yindia commented Jan 8, 2019

@YunfengZhao915 what's the benefit of that PR

@YunfengZhao915
Copy link
Contributor Author

@evalsocket
"open" project is deprecated. In its homepage, it remmonds using "opn":
https://github.com/jjrdn/node-open
The home page of "opn" is:
https://github.com/sindresorhus/opn

@yindia
Copy link

yindia commented Jan 9, 2019

Does it solve the vulnerability #35

@YunfengZhao915
Copy link
Contributor Author

Does it solve the vulnerability #35

Yes, it does.

@slunecniborecek
Copy link

@evalsocket @jsoverson is there a time frame for this to be merged and released? Thanks

@yindia
Copy link

yindia commented Feb 9, 2019

@slunecniborecek it's hard to say. Maintainer of this repo is not much active. So for now you can create fork from @jsoverson repo and use grunt-open

@jsoverson jsoverson merged commit 52d6b73 into jsoverson:master Mar 14, 2019
@jsoverson
Copy link
Owner

This was published to npm.

@YunfengZhao915
Copy link
Contributor Author

This was published to npm.

Thanks @jsoverson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants