Skip to content

Commit

Permalink
spelling: prerequisite
Browse files Browse the repository at this point in the history
Signed-off-by: Josh Soref <[email protected]>
  • Loading branch information
jsoref committed Nov 20, 2024
1 parent d685c4e commit e1a7e50
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/develop-resources/api-conventions/validations.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ If the field contains more complicated GCP behavior, for example the GCP server

Parent field should be required and immutable.

Note that parent is not a field name. It refers to the pre-requisite of the resource in question. You can identify the parent field through to the cloud resource's parent segment in the URL. For example, for GKE clusters, the [GET request URL](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.zones.clusters/get) `https://container.googleapis.com/v1/projects/{projectId}/zones/{zone}/clusters/{clusterId}` has `projectId` and `zone` in the parent segment. Therefore, for GKE clusters, projectRef and zone will be the parent fields.
Note that parent is not a field name. It refers to the prerequisite of the resource in question. You can identify the parent field through to the cloud resource's parent segment in the URL. For example, for GKE clusters, the [GET request URL](https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.zones.clusters/get) `https://container.googleapis.com/v1/projects/{projectId}/zones/{zone}/clusters/{clusterId}` has `projectId` and `zone` in the parent segment. Therefore, for GKE clusters, projectRef and zone will be the parent fields.


### Required
Expand Down
2 changes: 1 addition & 1 deletion pkg/test/controller/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func isTransientError(t *testing.T, err error) bool {
// We don't know the exact error currently, use string matching for now...
//
// Example error:
// reconcile.go:175: error was not considered transient; chain is [[*errors.errorString: Update call failed: error applying desired state: summary: failed pre-requisites: missing permission on "billingAccounts/0162D7-7B0CB6-ED962E": billing.resourceAssociations.create]]
// reconcile.go:175: error was not considered transient; chain is [[*errors.errorString: Update call failed: error applying desired state: summary: failed prerequisites: missing permission on "billingAccounts/0162D7-7B0CB6-ED962E": billing.resourceAssociations.create]]
if strings.Contains(errorMessage, "missing permission on") {
t.Logf("internal error found; considered transient; chain is %v", chain)
return true
Expand Down

0 comments on commit e1a7e50

Please sign in to comment.