Backports for 5.2.8 #558

erayd · 2019-01-10T04:34:08Z

Bugfixes from 6.0.0 that can be backported to 5.2.8 without breaking backwards-compatibility.

Backported PRs

Don't use PHP's fmod #470 Don't use PHP's fmod
Remove large array type-specific performance optimisation #498 Remove type-specific performance optimisation (anyOf Warning #441, Array properties with array items listed in enums does not validate properly #547)
Add HHVM to allow_failures in .travis.yml #520 Add hhvm to allow_failures
php-doc fix in bin/validate-json #528 Comment (phpdoc) fix in bin/validate-json
Fix: Pin friendsofphp/php-cs-fixer to minor version #537 Pin php-cs-fixer to minor version
feat: Exclude certain endpoints from media type validation #544 Exclude some endpoints from media type validation
Fix min/maxProperties check for invalid array input #545 Check invalid array input to min / max properties

Skipped PRs

Don't cast multipleOf to be an integer for the error message #471 Error message change - out of scope for 5.x.x (errors were rewritten for v6)
Add support for "const" #507 Add support for "const" - out of scope for 5.x.x
Strict Enum/Const Object Checking #518 Strict Enum/Const Object Checking - out of scope for 5.x.x
return original value when no cast #535 Return original value (this type of string coercion doesn't exist in 5.x.x)

Fixes jsonrainbow#441. The bug in jsonrainbow#441 was caused by refactoring of the optimisation which introduced a type-checking error. Noting the performance impact is negligible for all cases other than large arrays of strings or numbers, and introduces significant cognitive complexity to a project that is extremely short of maintainers, removing it seems like the best course of action. The performance improvement provided by this optimisation was approximately 40%, however it also carried a number of other problematic bugs - if it were to be reintroduced at a later date with those bugs fixed (mainly the skipping of much of the validation logic for optimised items, even in cases where that logic might be necessary), it would not have such a significant impact.

PHP's fmod has some quirks. The private fmod function wraps it to iron out some of those quirks but ultimately it's better to just not use it.

Now that the private fmod function is not using PHP's fmod we can remove the code which was working around it's quirks.

- Fixes jsonrainbow#543 and jsonrainbow#540

- Change stripos to strpos to match case-insensitive - Rename $mediaTypeBlacklist to $allowedInvalidContentTypeEndpoints - Refactor for to foreach

erayd · 2019-01-10T04:41:47Z

@bighappyface Could you please merge this when you have a moment?

bighappyface · 2019-01-15T00:07:02Z

@erayd thanks! See https://github.com/justinrainbow/json-schema/releases/tag/5.2.8

erayd and others added 14 commits January 10, 2019 17:01

Enhancement: Normalize composer.json

836048e

Don't use PHP's fmod

96a7fe5

PHP's fmod has some quirks. The private fmod function wraps it to iron out some of those quirks but ultimately it's better to just not use it.

Simplify the private fmod function

6b2a5cd

Now that the private fmod function is not using PHP's fmod we can remove the code which was working around it's quirks.

chore(travis): add hhvm to allow_failures

23d7b33

php-doc fix in bin/validate-json

a91222b

Fix: Pin friendsofphp/php-cs-fixer to minor version

5dd32e9

Fix: Remove unknown fixers

8daf5ee

feat: Add blacklisting of endpoints with invalid media types

d9dc83f

- Fixes jsonrainbow#543 and jsonrainbow#540

fix: spelling mistake

dfbdda3

fix: use example.com as example domains

9fac260

fix: Adjustments based on code review

bc14a6f

- Change stripos to strpos to match case-insensitive - Rename $mediaTypeBlacklist to $allowedInvalidContentTypeEndpoints - Refactor for to foreach

fix: Cleanup test names

1da6614

Fix min/maxProperties check for invalid array input

86dfb04

erayd mentioned this pull request Jan 10, 2019

Array properties with array items listed in enums does not validate properly #547

Closed

bighappyface merged commit dcb6e10 into jsonrainbow:5.x.x Jan 14, 2019

erayd deleted the backport-528 branch September 25, 2019 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports for 5.2.8 #558

Backports for 5.2.8 #558

erayd commented Jan 10, 2019 •

edited

Loading

erayd commented Jan 10, 2019

bighappyface commented Jan 15, 2019

Backports for 5.2.8 #558

Backports for 5.2.8 #558

Conversation

erayd commented Jan 10, 2019 • edited Loading

Backported PRs

Skipped PRs

erayd commented Jan 10, 2019

bighappyface commented Jan 15, 2019

erayd commented Jan 10, 2019 •

edited

Loading