Remove relationships key when having fields with no relationships specified #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The
fields
option was filling therelationships_hash
with an empty hash instead of not having it at all:But you can have some cases where you do have fieldsets but none of those fieldsets are related to the relationships. Instead of having no relationships at all, you will have then an empty hash, even though if you specifically specified you didn't want and relationships in your fields option.
See issue : #167
What is the new behavior?
IF there is a fieldset but that fieldset has no keys related to the relationships, the relationships_hash will return nil and will not be constructed.
IF there is a field with some keys related to the relationships, those keys will slice
relationships_to_serialize
to select the ones relatedIF there is no fieldset, all the keys of the relationships are selected
Checklist
features)
Disclaimer
This the first time I'm posting a PR for open source gem, but I'm doing my best! Looking forward for review / things to change.