Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement : Merge both greet-on-first-pr and merge in pull-request-target-yml #695

Merged
merged 3 commits into from
May 21, 2024
Merged

Enhancement : Merge both greet-on-first-pr and merge in pull-request-target-yml #695

merged 3 commits into from
May 21, 2024

Conversation

aialok
Copy link
Collaborator

@aialok aialok commented May 19, 2024

What kind of change does this PR introduce?

  • Merge both greet-on-first-pr and greet-on-first-merge in pull-request-target-yml

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

  • Currently, we are running two different workflows, greet_on_first_merge.yml and welcome-first-time-contrib.yml, for the pull request event for first-time contributors.
  • Creating pull-request-target.yml to handle all tasks related to pull requests, such as greeting first-time contributors or sending any pull request messages during creation.
  • Having all pull request tasks into a single workflow simplifies maintenance, ensures workflow consistency, and eliminates the need to manage multiple workflows for tasks like issuing comments and greeting first-time contributors on PRs.

Does this PR introduce a breaking change?

@aialok aialok requested a review from a team as a code owner May 19, 2024 17:51
@aialok aialok added the GSoC Google Summer of Code related label May 20, 2024
benjagm
benjagm approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Alok. Thanks!

@benjagm benjagm merged commit 3748a1a into json-schema-org:main May 21, 2024
3 checks passed
aialok added a commit to aialok/website that referenced this pull request May 27, 2024
@aialok
Enhancement : Merge both greet-on-first-pr and merge in pull-request-…
35eb8bc 
…target-yml (json-schema-org#695)

* Added pull-request-yml

* removed greet on first merge and welcome first time contributor

* Removed Issue-labeler-yml
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Jun 2, 2024
@aialok @Akshaybagai52
Enhancement : Merge both greet-on-first-pr and merge in pull-request-…
2e74329 
…target-yml (json-schema-org#695)

* Added pull-request-yml

* removed greet on first merge and welcome first time contributor

* Removed Issue-labeler-yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
GSoC Google Summer of Code related
Projects
None yet
Milestone
No milestone
2 participants
@aialok @benjagm