reserve dollar keywords for core vocab #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
I'm not sure how far we want to take this. Should implementations check vocabulary extensions to ensure they don't define $ keywords and throw an error if they do?
I think it's sufficient for it to be up to implementations to decide if they want to enforce this restriction. I think the proposed wording is all that's necessary.
4 tasks
Relequestual
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1321
I'm not sure how far we want to take this. Should implementations check vocabulary extensions to ensure they don't define
$keywords and throw an error if they do?