Fix 2019-09 hyperschema meta-schemas #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links.json schema uses `$recursiveRef` wrong. In fact, `$recursiveRef` is not capable of expressing the relationship that was intended. With this version, schemas in the `links` keyword are pinned to the 2019-09 hyperschema dialect even if `$recursiveRef` is used to extend the 2019-09 hyperschema dialect. While not exactly what was intended, this covers all but advanced use-cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1120
The links.json schema uses
$recursiveRefwrong. In fact,$recursiveRefis not capable of expressing the relationship that wasintended. With this version, schemas in the
linkskeyword are pinned to the 2019-09 hyperschema dialect even if$recursiveRefis used to extend the 2019-09 hyperschema dialect. While not exactly what was intended, this covers all but advanced use-cases.