Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vocabulary files and keyword dependencies. #1002

Closed
wants to merge 1 commit into from

Conversation

handrews
Copy link
Contributor

@handrews handrews commented Oct 1, 2020

This just covers the Core spec, the rest will be done
as a follow-on. Fixes #996.

Please read these instructions before commenting!

The following topics are in bounds for PR comments:

For smaller-scale sentence tweaking or wording preferences, please make notes in #847 but I don't want to get into that here. If it's clear enough to be understood, that's good enough for now.

The following topics are out of bounds for comments on this PR, but if you can build consensus on slack or wherever and come back here with something that has consensus behind it, I will gladly switch to the consensus view. I just don't want to debate alternatives myself (for reasons explained in detail on slack). If an alternative emerges with broad support, as long as I don't see a major problem I'll just accept it:

  • Other things that could be added
  • Different names for things
  • Completely different approaches

This just covers the Core spec, the rest will be done
as a follow-on.
@karenetheridge
Copy link
Member

I see this was closed.. but let's revisit next year for the next draft, as there are lots of gems in here that I don't want to lose.

@gregsdennis
Copy link
Member

gregsdennis commented Dec 8, 2020

@handrews wanted to do this for draft 07, but we never got to a place where we could define WHAT a keyword was. There's another issue (#911) floating around (I think @ssilverman or @jdesrosiers opened it) that goes into some ideas around metaschemas and vocabs that Henry summarily dismissed.

@Relequestual
Copy link
Member

Ok. Open another issue and reference this PR and that issue or PR and we will see what we can do! =D

@gregsdennis
Copy link
Member

Definitely not for this draft. Needs more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Minimalist vocabulary file for expressing keyword dependencies.
4 participants