-
-
Notifications
You must be signed in to change notification settings - Fork 214
Highlight our community and activities #420
Highlight our community and activities #420
Conversation
…lack server. Resolves json-schema-org#98 Resolves json-schema-org#99 Resolves json-schema-org#100
✔️ Deploy Preview for condescending-hopper-c3ed30 ready! 🔨 Explore the source changes: 46e2c5c 🔍 Inspect the deploy log: https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/618a3b788fc9fe0008017974 😎 Browse the preview: https://deploy-preview-420--condescending-hopper-c3ed30.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple minor issues.
I'm personally not a fan of the "Read more" buttons. I'd rather just see all the content. If something is large enough to be a bother it's better off being on its on page.
index.md
Outdated
### Got questions? | ||
We have an active and growing community. All are welcome to be part of our community, help shape it, or simply observe. | ||
|
||
We want keep our community welcoming and inclusive, so please read our [JSON Schema Organizational Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). (This is a combination of the Contributor Covenant and IETF BCP 54.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want keep our community welcoming and inclusive, so please read our [JSON Schema Organizational Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). (This is a combination of the Contributor Covenant and IETF BCP 54.) | |
We want to keep our community welcoming and inclusive, so please read our [JSON Schema Organizational Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). (This is a combination of the Contributor Covenant and IETF BCP 54.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github's email produces an alert here:
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github's email produces an alert here:
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Which email?
I don't believe there are any bidirectional unicode text. I have added some unicode characters.
I don't see the same warning.
You should also see the warning when viewing the file on GitHub, and I do not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github notification emails (and it also shows up in the slack notifications).
I suspect it's a bug with how github is generating diffs, and it's triggering their own heuristic.
It's quite annoying as now these notifications are useless as they don't show content.
Co-authored-by: Jason Desrosiers <[email protected]>
Co-authored-by: Jason Desrosiers <[email protected]>
I'm a fan, but I also agree. I'm trying to keep the changes small and incremental, so I'll log a new issue for migrating content from the home page to their own pages. |
Highlight and link to community discussions, regular calls, and our slack server.
Resolves json-schema-org/community/issues/98
Resolves json-schema-org/community/issues/99
Resolves json-schema-org/community/issues/100