Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Highlight our community and activities #420

Merged

Conversation

Relequestual
Copy link
Member

@Relequestual Relequestual commented Nov 4, 2021

Highlight and link to community discussions, regular calls, and our slack server.
Resolves json-schema-org/community/issues/98
Resolves json-schema-org/community/issues/99
Resolves json-schema-org/community/issues/100

@netlify
Copy link

netlify bot commented Nov 4, 2021

✔️ Deploy Preview for condescending-hopper-c3ed30 ready!

🔨 Explore the source changes: 46e2c5c

🔍 Inspect the deploy log: https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/618a3b788fc9fe0008017974

😎 Browse the preview: https://deploy-preview-420--condescending-hopper-c3ed30.netlify.app/

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple minor issues.

I'm personally not a fan of the "Read more" buttons. I'd rather just see all the content. If something is large enough to be a bother it's better off being on its on page.

index.md Outdated
### Got questions?
We have an active and growing community. All are welcome to be part of our community, help shape it, or simply observe.

We want keep our community welcoming and inclusive, so please read our [JSON Schema Organizational Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). (This is a combination of the Contributor Covenant and IETF BCP 54.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We want keep our community welcoming and inclusive, so please read our [JSON Schema Organizational Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). (This is a combination of the Contributor Covenant and IETF BCP 54.)
We want to keep our community welcoming and inclusive, so please read our [JSON Schema Organizational Code of Conduct](https://github.com/json-schema-org/.github/blob/main/CODE_OF_CONDUCT.md). (This is a combination of the Contributor Covenant and IETF BCP 54.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github's email produces an alert here:

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github's email produces an alert here:

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Which email?
I don't believe there are any bidirectional unicode text. I have added some unicode characters.
I don't see the same warning.
You should also see the warning when viewing the file on GitHub, and I do not.

Copy link
Member

@karenetheridge karenetheridge Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github notification emails (and it also shows up in the slack notifications).

I suspect it's a bug with how github is generating diffs, and it's triggering their own heuristic.
It's quite annoying as now these notifications are useless as they don't show content.

index.md Outdated Show resolved Hide resolved
Relequestual and others added 2 commits November 9, 2021 09:11
Co-authored-by: Jason Desrosiers <[email protected]>
Co-authored-by: Jason Desrosiers <[email protected]>
@Relequestual
Copy link
Member Author

I'm personally not a fan of the "Read more" buttons. I'd rather just see all the content. If something is large enough to be a bother it's better off being on its on page. - @jdesrosiers

I'm a fan, but I also agree. I'm trying to keep the changes small and incremental, so I'll log a new issue for migrating content from the home page to their own pages.
There is a challenege as to how you find those pages, as they may not fit in the menu.

@Relequestual Relequestual merged commit fec0d59 into json-schema-org:master Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants