-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR for Code of Conduct #41
Conversation
Review approvals from @jdesrosiers, @Julian, and @karenetheridge are required as they are "Deciders" in this ADR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo I suspect, but this is good with me personally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. However, as I read this, it occurs to me that it doesn't say much that isn't obvious, which leads me to wonder if it was really necessary for this to be an ADR.
ADRs are for us to come back years from now and be reminded of why we made a decision, not what decision was made. The reasons for why to adopt a CoC are a bit obvious, but they are articulated well. However, I think we can do more to say why we chose Contributor Covenant and BCP 54. For example,
- Why did we want to choose something established?
- Because we don't have the experience to do something custom
- Because we don't have community with unique needs that requires something custom
- Because we can get feedback and learn from other projects that use the same CoC
- Because people will feel more feel comfortable under a CoC they are familiar with from other communities
- Is BCP 54 just about treating people with respect? Do other parts of the document apply as well?
- General consensus?
Again, most of that feels a little obvious to the point that I'm not sure it needs documenting, but if we're going to document it, we should be specific. If we have to read between the lines when we read this in the future, then it wasn't very useful.
I think I agree strongly with that general point, though I'd also add that a secondary important thing to be able to look back on is purely that all of us have signed off on the change and put our name on it. But I don't disagree with writing down as much info as we can about why we made a decision, and that if the decision is obvious, that maybe an ADR may not be needed. (Also I suspect Ben's exercising his ADR muscles in part because we've just started using them :) |
I'll make some changes. Good call! |
If you can think of any more pros or cons, please make a suggestion in review to add them =] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Just need to fix a minor typo.
Co-authored-by: Jason Desrosiers <[email protected]>
Work required by #26