Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for Code of Conduct #41

Merged
merged 7 commits into from
Oct 1, 2021

Conversation

Relequestual
Copy link
Member

Work required by #26

@Relequestual
Copy link
Member Author

Review approvals from @jdesrosiers, @Julian, and @karenetheridge are required as they are "Deciders" in this ADR.

@Relequestual Relequestual requested a review from Julian August 26, 2021 16:22
Copy link
Member

@Julian Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo I suspect, but this is good with me personally.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. However, as I read this, it occurs to me that it doesn't say much that isn't obvious, which leads me to wonder if it was really necessary for this to be an ADR.

ADRs are for us to come back years from now and be reminded of why we made a decision, not what decision was made. The reasons for why to adopt a CoC are a bit obvious, but they are articulated well. However, I think we can do more to say why we chose Contributor Covenant and BCP 54. For example,

  • Why did we want to choose something established?
    • Because we don't have the experience to do something custom
    • Because we don't have community with unique needs that requires something custom
    • Because we can get feedback and learn from other projects that use the same CoC
    • Because people will feel more feel comfortable under a CoC they are familiar with from other communities
  • Is BCP 54 just about treating people with respect? Do other parts of the document apply as well?
    • General consensus?

Again, most of that feels a little obvious to the point that I'm not sure it needs documenting, but if we're going to document it, we should be specific. If we have to read between the lines when we read this in the future, then it wasn't very useful.

@Julian
Copy link
Member

Julian commented Aug 31, 2021

I think I agree strongly with that general point, though I'd also add that a secondary important thing to be able to look back on is purely that all of us have signed off on the change and put our name on it.

But I don't disagree with writing down as much info as we can about why we made a decision, and that if the decision is obvious, that maybe an ADR may not be needed.

(Also I suspect Ben's exercising his ADR muscles in part because we've just started using them :)

@Relequestual
Copy link
Member Author

I'll make some changes. Good call!

@Relequestual Relequestual self-assigned this Sep 3, 2021
@Relequestual
Copy link
Member Author

If you can think of any more pros or cons, please make a suggestion in review to add them =]

Removed "brilliant", which is subjective.
Fixed typo, "de-factor" -> "de-facto" 😅
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just need to fix a minor typo.

docs/adr/2021-08-26-code-of-conduct.md Outdated Show resolved Hide resolved
Co-authored-by: Jason Desrosiers <[email protected]>
@Relequestual Relequestual merged commit 0797353 into json-schema-org:main Oct 1, 2021
@Relequestual Relequestual deleted the adr/coc branch October 1, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants