Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Add Postman case study #35

Merged
merged 11 commits into from
Aug 17, 2023

Conversation

Relequestual
Copy link
Member

@Relequestual Relequestual commented Jul 17, 2023

This case study is a reposting, with permission, from the Postman blog: https://blog.postman.com/how-postman-uses-json-schema

Thanks to @jviotti for being such a great internal ally and finding out lots of useful information about where JSON Schema is used in Postman.

Closes json-schema-org/community#215

@jviotti
Copy link
Member

jviotti commented Jul 17, 2023

Any time!

@Julian
Copy link
Member

Julian commented Jul 31, 2023

I left some minor comments just making sure it was clear that the voice of "us" here is "Postman" not "JSON Schema" -- probably good to change those. It might also be good to have a very short disclaimer saying "A number of members of the JSON Schema organization are employed by Postman, but this post is not sponsored content." or whatever -- but not critical, think it's probably fine to leave it out too. But overall, lgtm, feel free to merge as far as I'm concerned.

Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gregsdennis
Copy link
Member

Is there no build for this? It looks like you have some styled elements. It'd be good to verify those work with the preview.

Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good. Some formatting questions, and I agree with @Julian that the "we" first person feels odd here. Maybe you just missed one.

pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
pages/posts/postman-case-study.md Show resolved Hide resolved
pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
@Relequestual
Copy link
Member Author

@gregsdennis I believe I managed to resolve all your comments.
Here's a render:

View render

Screenshot 2023-08-10 at 10-48-56 How Postman uses JSON Schema JSON Schema Blog

pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
pages/posts/postman-case-study.md Outdated Show resolved Hide resolved
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure why the site preview isn't available, but that's a separate issue.

@Relequestual Relequestual merged commit 3dc172c into json-schema-org:main Aug 17, 2023
1 check passed
@Relequestual Relequestual deleted the postman-case-study branch August 17, 2023 14:06
@Relequestual
Copy link
Member Author

Still not sure why the site preview isn't available, but that's a separate issue.

Previews for CloudFlare do not work for forks. For the new site, we will have to have a policy of JSON Schema team making PRs on branches as opposed to forks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postman case study
4 participants