All format test cases should be under the format directory.
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there exists an ecma regex test case that uses `"format": "regex"`. My understanding was that all tests that require format validation where implemented under the `optional/format` directory. (As per point json-schema-org#2 of https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/9fc880bfb6d8ccd093bc82431f17d13681ffae8e/README.md#additional-assumptions). As such, this change moves the test requiring `format` under the `optional/format` directory.
This was referenced Jun 22, 2024
karenetheridge
approved these changes
Jun 22, 2024
|
@karenetheridge is there something stopping this being merged? |
|
@karenetheridge is there something stopping this being merged? |
|
Apologies, my mail filter for mentions was broken so I didn't see the nudges previously. this is good to go, so merging! |
|
No worries - thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: creek-service/json-schema-validation-comparison#190
Currently, there exists an ecma regex test case, that uses
"format": "regex", but which does not live under theoptional/formatdirectory.My understanding was that all tests that require format validation from implementations where under the
optional/formatdirectory. (As per point #2 under the Additional Assumptions section of the docs).Having this one test case outside of the directory complicates the implementations of all test runners and the need to turn on format validation for this one test case isn't even documented.
As such, this change moves the test requiring
formatunder theoptional/formatdirectory.This change was prompted by: creek-service/json-schema-validation-comparison#190