add more anchor validation tests #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
commented
Mar 17, 2024
There was a problem hiding this comment.
Technically the 2019-09 format is the same for previous versions, but it's in $id instead. I can try to make those changes as well, if desired.
|
Ah, yeah, I remember seeing that. While I don't disagree with the argument, I hadn't noticed the pattern change, and I feel that this would have caught my error. |
|
I guess we really just need a way to say, "This schema is invalid," which is something that seems to keep coming up. |
|
I'm going to close this in favor of #718. I'll need to add these tests locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a user report that my library isn't checking anchors correctly. Apparently I missed that the allowable characters changed from 2019-09 (and previous) to 2020-12.
This PR adds more tests for anchor validity.
I have updated my implementation and verified these new tests against it.