Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output: ensure ~ and / are escaped in json-pointer #654

Merged
merged 1 commit into from
Mar 30, 2023
Merged

output: ensure ~ and / are escaped in json-pointer #654

merged 1 commit into from
Mar 30, 2023

Conversation

santhosh-tekuri
Copy link
Contributor

No description provided.

@santhosh-tekuri santhosh-tekuri requested a review from a team as a code owner March 9, 2023 18:41
@gregsdennis
Copy link
Member

Nice test! I'm not sure I'd have thought of this.

I'll run it through my implementation in a bit.

@gregsdennis gregsdennis mentioned this pull request Mar 10, 2023
Open
@santhosh-tekuri
Copy link
Contributor Author

added similar test to draft-2019;

tests pass with impl https://github.com/santhosh-tekuri/boon

gregsdennis
gregsdennis approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pass for me.

@Julian
Copy link
Member

Julian commented Mar 29, 2023

Is this PR waiting on something?

@gregsdennis
Copy link
Member

gregsdennis commented Mar 30, 2023 •
edited
Loading

I think we wanted to start making sure that at least two other implementations agree on the test result.

@Julian
Copy link
Member

Julian commented Mar 30, 2023

Not I at least. But feel free to do so then if you'd like then.

@gregsdennis gregsdennis merged commit 47958f8 into json-schema-org:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsdennis gregsdennis gregsdennis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santhosh-tekuri @gregsdennis @Julian