-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break optional/ into more granular directories. #590
Open
Julian
wants to merge
6
commits into
main
Choose a base branch
from
bye-optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8f32e4f
Remove some unnecessary keywords from the format assertion tests.
Julian 9d226e0
Break optional/ into more granular directories.
Julian e332ecc
Add the 'conflicting' alternative files for content and format tests.
Julian 04d2ee5
Fix one more reference to optional/ in the README.
Julian c543281
Move dependencies tests from may to additional.
Julian 6c96b03
may/ doesn't technically exist anymore in any draft, so loosen the RE…
Julian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
tests/draft-next/alternatives/false-vocabulary-format-assertion/is-unknown.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
[ | ||
{ | ||
"description": "schema that uses custom metaschema with format-assertion: false", | ||
"comment": "For implementations which do not support the format assertion vocabulary", | ||
"schema": { | ||
"$schema": "http://localhost:1234/draft2020-12/format-assertion-false.json", | ||
"format": "ipv4" | ||
}, | ||
"tests": [ | ||
{ | ||
"description": "format-assertion: false: valid string", | ||
"data": "127.0.0.1", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "format-assertion: false: invalid string", | ||
"data": "not-an-ipv4", | ||
"valid": true | ||
} | ||
] | ||
} | ||
] |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
tests/draft2020-12/alternatives/false-vocabulary-format-assertion/is-unknown.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
[ | ||
{ | ||
"description": "schema that uses custom metaschema with format-assertion: false", | ||
"comment": "For implementations which do not support the format assertion vocabulary", | ||
"schema": { | ||
"$schema": "http://localhost:1234/draft2020-12/format-assertion-false.json", | ||
"format": "ipv4" | ||
}, | ||
"tests": [ | ||
{ | ||
"description": "format-assertion: false: valid string", | ||
"data": "127.0.0.1", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "format-assertion: false: invalid string", | ||
"data": "not-an-ipv4", | ||
"valid": true | ||
} | ||
] | ||
} | ||
] |
1 change: 1 addition & 0 deletions
1
...aft2020-12/optional/ecmascript-regex.json → ...draft2020-12/should/ecmascript-regex.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
[ | ||
{ | ||
"description": "validation of string-encoded content based on media type", | ||
"schema": { | ||
"contentMediaType": "application/json" | ||
}, | ||
"tests": [ | ||
{ | ||
"description": "a valid JSON document", | ||
"data": "{\"foo\": \"bar\"}", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "an invalid JSON document", | ||
"data": "{:}", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "ignores non-strings", | ||
"data": 100, | ||
"valid": true | ||
} | ||
] | ||
}, | ||
{ | ||
"description": "validation of binary string-encoding", | ||
"schema": { | ||
"contentEncoding": "base64" | ||
}, | ||
"tests": [ | ||
{ | ||
"description": "a valid base64 string", | ||
"data": "eyJmb28iOiAiYmFyIn0K", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "an invalid base64 string (% is not a valid character)", | ||
"data": "eyJmb28iOi%iYmFyIn0K", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "ignores non-strings", | ||
"data": 100, | ||
"valid": true | ||
} | ||
] | ||
}, | ||
{ | ||
"description": "validation of binary-encoded media type documents", | ||
"schema": { | ||
"contentMediaType": "application/json", | ||
"contentEncoding": "base64" | ||
}, | ||
"tests": [ | ||
{ | ||
"description": "a valid base64-encoded JSON document", | ||
"data": "eyJmb28iOiAiYmFyIn0K", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "a validly-encoded invalid JSON document", | ||
"data": "ezp9Cg==", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "an invalid base64 string that is valid JSON", | ||
"data": "{}", | ||
"valid": true | ||
}, | ||
{ | ||
"description": "ignores non-strings", | ||
"data": 100, | ||
"valid": true | ||
} | ||
] | ||
} | ||
] |
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is removing the
$id
going to break things? (cc: @karenetheridge) (seen in several places)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure no, it's just an extra unneeded validator that was in these schemas.