Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET Core 5 with EF Core 6 Preview 3 #978

Closed
wants to merge 4 commits into from

Conversation

bart-degreed
Copy link
Contributor

This PR shows that using EF Core 6 Preview 3, all of our existing tests succeed with the workaround for dotnet/efcore#21026 removed.

This PR is not meant to be merged.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #978 (bf241bd) into master (20308b0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head bf241bd differs from pull request most recent head c6c2b74. Consider uploading reports for the commit c6c2b74 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   91.26%   91.29%   +0.03%     
==========================================
  Files         281      281              
  Lines        7429     7425       -4     
==========================================
- Hits         6780     6779       -1     
+ Misses        649      646       -3     
Impacted Files Coverage Δ
...tCoreExample/Definitions/ArticleHooksDefinition.cs 100.00% <100.00%> (ø)
...cOperations/Processors/SetRelationshipProcessor.cs 100.00% <100.00%> (ø)
...NetCore/Configuration/InverseNavigationResolver.cs 100.00% <100.00%> (ø)
...NetCore/Configuration/JsonApiApplicationBuilder.cs 100.00% <100.00%> (ø)
.../JsonApiDotNetCore/Configuration/JsonApiOptions.cs 100.00% <100.00%> (ø)
...otNetCore/Configuration/JsonApiValidationFilter.cs 100.00% <100.00%> (ø)
src/JsonApiDotNetCore/Configuration/PageNumber.cs 46.66% <100.00%> (ø)
...e/Configuration/ResourceDescriptorAssemblyCache.cs 100.00% <100.00%> (ø)
...piDotNetCore/Configuration/ResourceGraphBuilder.cs 95.45% <100.00%> (ø)
...tCore/Configuration/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20308b0...c6c2b74. Read the comment docs.

@bart-degreed bart-degreed deleted the net6preview3 branch April 21, 2021 14:51
@bart-degreed bart-degreed restored the net6preview3 branch April 23, 2021 09:00
@bart-degreed
Copy link
Contributor Author

bart-degreed commented Apr 23, 2021

Bug for suppressed warning on HttpRequest.ContentType in JsonApiMiddleware.ValidateContentTypeHeaderAsync tracked at: dotnet/aspnetcore#32097.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant