-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try .NET/EF 9 RC2 #1550
base: master
Are you sure you want to change the base?
Try .NET/EF 9 RC2 #1550
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1550 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 349 349
Lines 11314 11315 +1
Branches 1849 1849
=======================================
+ Hits 10272 10274 +2
- Misses 682 683 +1
+ Partials 360 358 -2 ☔ View full report in Codecov by Sentry. |
dedc89f
to
e7ce58b
Compare
6da1d24
to
2bec731
Compare
e1aa16a
to
c5d0800
Compare
Hi - is there a preview Nuget of this anywhere we can try against our own code? |
I don't think there's a need for that. EF Core 9 targets .NET 8, so the current JADNC version should work already with EF Core 9 on both .NET 8 and 9. |
I've created #1619 to verify all tests are green when running on .NET 9 RC2 with EF Core 9 RC2, while still referencing JADNC that targets only .NET 8 and 6. While there are breaking changes in the EF Core driver API (so you'll need matching versions for PostgreSQL, MySQL, SQL Server, etc.), it appears that JADNC itself is already compatible. This means we don't need to release a new version of JADNC when .NET 9 ships. |
df0d535
to
4a11709
Compare
4a11709
to
8b76268
Compare
Explores multi-targeting against .NET 9 with EF Core 9 pre-release versions. This PR is experimental and not intended to be merged.
Blocked by:
Split query with AsNoTrackingWithIdentityResolution() throws ArgumentOutOfRangeException dotnet/efcore#34728https://youtrack.jetbrains.com/issue/RSRP-498478/Breaking-primary-constructors-with-readonly-fieldNullReferenceException from CSharpPreferGenericOverloadsAnalyzer in .NET 9 RC1 dotnet/roslyn-analyzers#7421