Removed workaround for dotnet/efcore#21026

json-api-dotnet · Dec 3, 2021 · a03ba2e · a03ba2e
1 parent 3b23f82
commit a03ba2e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 24 deletions.
diff --git a/src/JsonApiDotNetCore/Configuration/JsonApiOptions.cs b/src/JsonApiDotNetCore/Configuration/JsonApiOptions.cs
@@ -22,10 +22,6 @@ public sealed class JsonApiOptions : IJsonApiOptions
         /// <inheritdoc />
         JsonSerializerOptions IJsonApiOptions.SerializerWriteOptions => _lazySerializerWriteOptions.Value;
 
-        // Workaround for https://github.com/dotnet/efcore/issues/21026
-        internal bool DisableTopPagination { get; set; }
-        internal bool DisableChildrenPagination { get; set; }
-
         /// <inheritdoc />
         public string? Namespace { get; set; }
 

diff --git a/src/JsonApiDotNetCore/Queries/Internal/QueryLayerComposer.cs b/src/JsonApiDotNetCore/Queries/Internal/QueryLayerComposer.cs
@@ -172,7 +172,7 @@ private QueryLayer ComposeTopLayer(IEnumerable<ExpressionInScope> constraints, R
             {
                 Filter = GetFilter(expressionsInTopScope, resourceType),
                 Sort = GetSort(expressionsInTopScope, resourceType),
-                Pagination = ((JsonApiOptions)_options).DisableTopPagination ? null : topPagination,
+                Pagination = topPagination,
                 Projection = GetProjectionForSparseAttributeSet(resourceType)
             };
         }
@@ -238,9 +238,7 @@ private IImmutableSet<IncludeElementExpression> ProcessIncludeSet(IImmutableSet<
                     {
                         Filter = isToManyRelationship ? GetFilter(expressionsInCurrentScope, resourceType) : null,
                         Sort = isToManyRelationship ? GetSort(expressionsInCurrentScope, resourceType) : null,
-                        Pagination = isToManyRelationship
-                            ? ((JsonApiOptions)_options).DisableChildrenPagination ? null : GetPagination(expressionsInCurrentScope, resourceType)
-                            : null,
+                        Pagination = isToManyRelationship ? GetPagination(expressionsInCurrentScope, resourceType) : null,
                         Projection = GetProjectionForSparseAttributeSet(resourceType)
                     };
 

diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/Filtering/FilterDepthTests.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/Filtering/FilterDepthTests.cs
@@ -27,9 +27,6 @@ public FilterDepthTests(IntegrationTestContext<TestableStartup<QueryStringDbCont
 
             var options = (JsonApiOptions)testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();
             options.EnableLegacyFilterNotation = false;
-
-            options.DisableTopPagination = false;
-            options.DisableChildrenPagination = false;
         }
 
         [Fact]
@@ -370,11 +367,6 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
                 await dbContext.SaveChangesAsync();
             });
 
-            // Workaround for https://github.com/dotnet/efcore/issues/21026
-            var options = (JsonApiOptions)_testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();
-            options.DisableTopPagination = false;
-            options.DisableChildrenPagination = true;
-
             const string route = "/blogPosts?include=labels&filter[labels]=equals(name,'Hot')";
 
             // Act

diff --git a/...DotNetCoreTests/IntegrationTests/QueryStrings/Pagination/PaginationWithTotalCountTests.cs b/...DotNetCoreTests/IntegrationTests/QueryStrings/Pagination/PaginationWithTotalCountTests.cs
@@ -34,9 +34,6 @@ public PaginationWithTotalCountTests(IntegrationTestContext<TestableStartup<Quer
             options.MaximumPageSize = null;
             options.MaximumPageNumber = null;
             options.AllowUnknownQueryStringParameters = true;
-
-            options.DisableTopPagination = false;
-            options.DisableChildrenPagination = false;
         }
 
         [Fact]
@@ -350,11 +347,6 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
                 await dbContext.SaveChangesAsync();
             });
 
-            // Workaround for https://github.com/dotnet/efcore/issues/21026
-            var options = (JsonApiOptions)_testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();
-            options.DisableTopPagination = true;
-            options.DisableChildrenPagination = false;
-
             const string route = "/blogPosts?include=labels&page[number]=labels:2&page[size]=labels:1";
 
             // Act