Install node using nvm #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpluscode
commented
Nov 6, 2021
| @@ -1,4 +1,4 @@ | |||
| FROM node:current-stretch-slim | |||
| FROM node:current-stretch | |||
There was a problem hiding this comment.
Less slim image which comes with curl
tpluscode
commented
Nov 6, 2021
entrypoint.sh
Outdated
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.2/install.sh | bash | ||
| [ -s "$HOME/.nvm/nvm.sh" ] && \. "$HOME/.nvm/nvm.sh" | ||
|
|
||
| nvm install |
There was a problem hiding this comment.
I install netlify-cli first, because once nvm installs into $HOME it is no longer possible to install globally.
Better ideas welcome
jsmrcaga
requested changes
Nov 7, 2021
|
Also, add yourself in a Contributors section on the README! I completely forgot to ;) |
jsmrcaga
approved these changes
Nov 10, 2021
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 17 broke my webpack build because of changes in OpenSSL
In this PR I added support for
.nvmrcfile so that the right node version will be installed if overridden in the repo.