Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npmjs.com release for additional SPDX code added needed #2

Closed
Martii opened this issue Feb 6, 2018 · 5 comments
Closed

npmjs.com release for additional SPDX code added needed #2

Martii opened this issue Feb 6, 2018 · 5 comments

Comments

@Martii
Copy link
Contributor

Martii commented Feb 6, 2018

https://www.npmjs.com/package/spdx-osi doesn't seem to include 8b69d8f thus blocking https://www.npmjs.com/package/spdx-is-osi and indirectly https://www.npmjs.com/package/spdx-license-ids in our implementation.

Will we expect an update soon please?

Thanks for a moment of your time.
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Feb 6, 2018
@Martii
Some dep updates
f960b29 
* Holding off on *spdx-osi* since latest SPDX 3.x changes weren't implemented. See jslicense/spdx-osi.json#2
* *bootstrap*@4.x is out however last time I tried it there were issues with dropdowns not being positioned correctly Ref: OpenUserJS#1277 ... holding off until retesting again
* *mongoose* breaking changes not tested yet... holding off
* *mongodb* breaking changes not tested yet... holding off
Martii added a commit to OpenUserJS/OpenUserJS.org that referenced this issue Feb 6, 2018
@Martii
Some dep updates (#1322)
8d90bfa 
* Holding off on *spdx-osi* since latest SPDX 3.x changes weren't implemented. See jslicense/spdx-osi.json#2
* *bootstrap*@4.x is out however last time I tried it there were issues with dropdowns not being positioned correctly Ref: #1277 ... holding off until retesting again
* *mongoose* breaking changes not tested yet... holding off
* *mongodb* breaking changes not tested yet... holding off

Auto-merge
@Martii Martii changed the title npmjs.com release for additional SPDX 3.x code added needed npmjs.com release for additional SPDX 2.x code added needed Feb 10, 2018
@Martii Martii changed the title npmjs.com release for additional SPDX 2.x code added needed npmjs.com release for additional SPDX code added needed Jul 9, 2018
@Martii
Copy link
Contributor Author

Martii commented Jul 9, 2018

*Gentle reminder bump*

@kemitchell
Copy link
Member

2.0.0 coming soon.

I've added you as a collaborator this repo. Please send PRs for significant changes.

@Martii
Copy link
Contributor Author

Martii commented Jul 9, 2018

Thanks. Now that 2.0.0 of this is on npmjs.com, should the package that has this dependency be updated too at the line of /jslicense/spdx-is-osi.js/blob/35add02/package.json#L7 along with a version bump over there? e.g. do you want a PR over there after some brief manual testing?

@kemitchell
Copy link
Member

@Martii, by all means, do what you can.

@Martii
Copy link
Contributor Author

Martii commented Jul 10, 2018 •
edited
Loading

Done... closing.

I've added you as a collaborator this repo. Please send PRs for significant changes.

Thanks but due to a recent change with your administration over at jslicense/spdx-is-osi.js#2 (comment) I have left being a collaborator from your organization.

@Martii Martii closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Martii @kemitchell