Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_robot_startup/lifelog] Tweet randomly from uptime #1803

Merged

Conversation

tkmtnt7000
Copy link
Member

develop/fetch version

This PR enables robot to tweet for random minutes instead of elapsed time since robot starts.

@k-okada
Copy link
Member

k-okada commented Jun 7, 2023

@tkmtnt7000 I think this feature could be the default.

@tkmtnt7000
Copy link
Member Author

Yes, I would like to execute this node in the default.

@k-okada
Copy link
Member

k-okada commented Jun 7, 2023

I mean enable this feature withtout explictly define "/active_user/tweet_random_range" in each launch files.

Comment on lines +24 to +25
(t
(setq *tweet-random-range* 600.0)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section sets random range without explicitly setting rosparm /active_user/tweet_random_range

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you're right.

@sktometometo sktometometo merged commit 609ad33 into jsk-ros-pkg:develop/fetch Jun 16, 2023
@tkmtnt7000 tkmtnt7000 deleted the PR-tweet-random-time branch October 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants