Skip to content

Commit

Permalink
Switch test from avro-python3 to avro.
Browse files Browse the repository at this point in the history
This picks up the fix dropping setup_requires in:
  apache/avro#818
  • Loading branch information
jsirois committed Dec 10, 2023
1 parent 945e137 commit b9ec3c8
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tests/integration/test_issue_1537.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,13 @@
import shutil
import subprocess

import pytest

from pex.compatibility import PY3
from pex.typing import TYPE_CHECKING
from testing import run_pex_command

if TYPE_CHECKING:
from typing import Any, Callable, ContextManager, Tuple


@pytest.mark.skipif(
condition=not PY3, reason="Test relies on a distribution that is Python 3 only."
)
def test_rel_cert_path(
run_proxy, # type: Callable[[], ContextManager[Tuple[int, str]]]
tmpdir, # type: Any
Expand All @@ -32,7 +26,12 @@ def test_rel_cert_path(
"http://localhost:{port}".format(port=port),
"--cert",
"cert",
"avro-python3==1.10.0",
# N.B.: The original issue (https://github.com/pantsbuild/pex/issues/1537) involved
# avro-python3 1.10.0, but that distribution utilizes setup_requires which leads to
# issues in CI for Mac. We use the Python 2/3 version of the same distribution
# instead, which had setup_requires removed in
# https://github.com/apache/avro/pull/818.
"avro==1.10.0",
"-o",
pex_file,
]
Expand Down

0 comments on commit b9ec3c8

Please sign in to comment.