Skip to content

Commit

Permalink
Drill down on non-empty TERM.
Browse files Browse the repository at this point in the history
  • Loading branch information
jsirois committed Dec 3, 2023
1 parent bc7bd3e commit 195b2e5
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 2 deletions.
44 changes: 43 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,45 @@ jobs:
- pypy310-pip20
- pypy310-pip22_3_1
- pypy310-pip23_1_2
steps:
- name: Free Up Disk Space
uses: jlumbroso/[email protected]
with:
android: true # ~14GB
dotnet: true # ~2GB
tool-cache: true # ~12GB

# Too little space savings or too slow.
haskell: false
large-packages: false
docker-images: false
swap-storage: false
- name: Checkout Pex
uses: actions/checkout@v3
with:
# We need branches and tags for some ITs.
fetch-depth: 0
# Some ITs need this for VCS URLs of the form git+ssh://[email protected]/...
- name: Setup SSH Agent
uses: webfactory/[email protected]
env:
SSH_PRIVATE_KEY: ${{ secrets.SSH_PRIVATE_KEY }}
if: env.SSH_PRIVATE_KEY != ''
with:
ssh-private-key: ${{ env.SSH_PRIVATE_KEY }}
- name: Run Tests
run: |
TERM=xterm \
BASE_MODE=pull \
CACHE_MODE=pull \
./dtox.sh -e ${{ matrix.tox-env }} -- ${{ env._PEX_TEST_POS_ARGS }}
linux-tests-2:
name: ./dtox.sh -e ${{ matrix.tox-env }}
needs: org-check
runs-on: ubuntu-22.04
strategy:
matrix:
tox-env:
- py27-pip20-integration
- py37-pip22_3_1-integration
- py37-pip23_1_2-integration
Expand Down Expand Up @@ -98,7 +137,10 @@ jobs:
ssh-private-key: ${{ env.SSH_PRIVATE_KEY }}
- name: Run Tests
run: |
BASE_MODE=pull CACHE_MODE=pull ./dtox.sh -e ${{ matrix.tox-env }} -- ${{ env._PEX_TEST_POS_ARGS }}
TERM=xterm \
BASE_MODE=pull \
CACHE_MODE=pull \
./dtox.sh -e ${{ matrix.tox-env }} -- ${{ env._PEX_TEST_POS_ARGS }}
mac-tests:
name: tox -e ${{ matrix.tox-env }}
needs: org-check
Expand Down
1 change: 1 addition & 0 deletions dtox.sh
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ exec docker run \
--volume pex-caches:/development/pex_dev \
--volume "${ROOT}:/development/pex" \
--volume pex-tox:/development/pex/.tox \
--env TERM="${TERM}" \
"${DOCKER_ARGS[@]}" \
"pantsbuild/pex/user:${user_hash}" \
"$@"
Expand Down
1 change: 0 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ passenv =
SSH_AUTH_SOCK
# Needed for interactive tests.
TERM
TERMINFO
setenv =
pip20: _PEX_PIP_VERSION=20.3.4-patched
pip22_2: _PEX_PIP_VERSION=22.2.2
Expand Down

0 comments on commit 195b2e5

Please sign in to comment.