-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 support for phyloseq and TreeSE #17
Conversation
This PR is now ready. Summary of changes:
After merging, this should be bumped to Bioc devel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting all this together. I think this is a very nice contribution. Overall I just had two comments about adding required dependencies and about changing the default behavior of the philr function.
Happy to discuss more if you feel strongly on either.
…ired as input (no SummarizedExperiment support as that is missing tree)
All requested changes implemented, with some bioc stilization. Happy to make further fixes if there is a need. We could change philr input argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for all this work. I think I found one error in the proposed pull -- defaults don't seem to have been changed in the main s3 function, only in the individual methods.
I think this will cause problems.
I think I have now made all requested changes but if not, let us continue discussion & fixing. |
This looks great. Also I think you are correct, my appologies for the confusion regarding the default weights. Thank you for your patience and hard work. Merging now. |
Awesome, thanks - pleasure to contribute to such a great package! The phylofactor is possible next target. I anticipate that the updates will be also pushed to Bioconductor devel upstream to facilitate further use: I noticed that running the standard check BiocCheck::BiocCheck() generates some more suggested coding style updates. But I expect that those are not mandatory for already accepted packages. |
Opening this PR related to philr issue #16
All checks pass and this can be reviewed & necessary changes discussed but two things are pending before merge:
TreeSE
examples is required from thereKindly review and suggest any modifications.