moves react and it's packages to peer deps and update build to use rollup instead of webpack #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our project's upgrade to React 16 has been blocked a bit due to
|
|
+1 |
1 similar comment
|
+1 |
|
Thanks, mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and foremost I'm really sorry for such a verbose PR.
This solves #55 by moving react, react-dom and prop-types to peer dependencies, avoiding conflicts with the versions of this packages installed by the dev.
And it solves #54 as well, by replacing webpack with rollup which is more suited for libraries than it's contender.
Hope you enjoy my effort... Your package is a life saver for me.
Thank you very much : )