Add nilcheck to commission scale in event of insufficient sp balance

jshufro · Nov 25, 2024 · b47a29b · b47a29b
1 parent eae26d9
commit b47a29b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/shared/services/rewards/generator-impl-v9-v10-rolling.go b/shared/services/rewards/generator-impl-v9-v10-rolling.go
@@ -687,6 +687,9 @@ func (r *treeGeneratorImpl_v9_v10_rolling) calculateNodeRewards() (*big.Int, *bi
 				// Calculate the reduced bonus for each minipool
 				// Because of integer division, this will be less than the actual bonus by up to 1 wei
 				for _, mpd := range nsd.Minipools {
+					if mpd.MinipoolBonus == nil {
+						continue
+					}
 					mpd.MinipoolBonus.Mul(mpd.MinipoolBonus, remainingBalance)
 					mpd.MinipoolBonus.Div(mpd.MinipoolBonus, totalConsensusBonus)
 				}

diff --git a/shared/services/rewards/generator-impl-v9-v10.go b/shared/services/rewards/generator-impl-v9-v10.go
@@ -740,6 +740,9 @@ func (r *treeGeneratorImpl_v9_v10) calculateNodeRewards() (*big.Int, *big.Int, *
 				// Calculate the reduced bonus for each minipool
 				// Because of integer division, this will be less than the actual bonus by up to 1 wei
 				for _, mpd := range nsd.Minipools {
+					if mpd.MinipoolBonus == nil {
+						continue
+					}
 					mpd.MinipoolBonus.Mul(mpd.MinipoolBonus, remainingBalance)
 					mpd.MinipoolBonus.Div(mpd.MinipoolBonus, totalConsensusBonus)
 				}