-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option preferred encodings array #59
Added an option preferred encodings array #59
Conversation
@dougwilson Would you mind adding a minor change to |
@dougwilson thanks for shepherding this along. |
bc54508
to
eb36d5d
Compare
After merging this I was looking at the api and realized we are limiting ourselves by passing an array directly, so I wrapped it in an options object so we have less of a chance of needing to break that api in future changes. That is what I will release with 1.0. |
@blakeembrey This PR can be backported to version 0; it is necessary for |
@bjohansebas any reason compression can’t be bumped to 1.0 and do its own major release for the feature? |
|
While I agree generally, I’d recommend bumping the major version and minimum node version for compression. It’s not as big a deal as you might expect, since there’s no other breaking changes except node version support, and would allow you to avoid feature flagging brotli support since it only exists around node v12. Since you aren’t breaking any other features, people can freely upgrade to v2 if they’re using a newer node version. I don’t think it’ll be an issue for people who want brotli support to be using a supported node version. |
OK, I just checked out master from this merge commit and released that directly as 0.6.4. Does that work for you? |
It's working well, although we need to integrate this option into |
Will be used in expressjs/compression#172