Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quote parsing from package #180

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

blakeembrey
Copy link
Member

Another RFC (cc @gurgunday). Removes a single check that wouldn't be relevant if this package set the cookie to begin with. Clients do not surreptitiously add quotes to cookies (as far as I know?), it's just a cookie value is valid to be surrounded by quotes.

Copy link
Contributor

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakeembrey blakeembrey marked this pull request as ready for review October 8, 2024 19:14
@blakeembrey
Copy link
Member Author

@gurgunday I think if we're expecting other applications (re #179 (comment)) it might be an issue merging this. Since another application might be using quotes. I'm still of the opinion that it's fine to shift this responsibility into decode though, since adding the quotes would be a job for encode.

@gurgunday
Copy link
Contributor

gurgunday commented Oct 8, 2024

Yeah, just checked the RFC again, nothing about this quote removal behavior

So I agree then that this should be a decoder responsibility, and since the default encoder doesn't do quotes, I don't see any reason to expect or even try to unquote values

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8f3ee9e) to head (661b48d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          159       152    -7     
  Branches        67        65    -2     
=========================================
- Hits           159       152    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakeembrey blakeembrey merged commit c4a2597 into master Oct 8, 2024
10 checks passed
@blakeembrey blakeembrey deleted the be/remove-quote-parsing branch October 8, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants