Public status index #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the settings are set up correctly
…d to before adding any new tests (if I am doing that...) and actually implementing the search part of this
…e a status also try to write it to the public status. The chewy index will take care of the rest for us and figure out what should actually happen
ClearlyClaire
pushed a commit
that referenced
this pull request
Aug 23, 2023
* Add a new public status index * Create an importer for the new index * Try to add a vaccuum thing * quick lint * make sure that the settings are correct. TODO: add a test making sure the settings are set up correctly * One more easy one... * Hunt down all the status index usage except for the actual searching and the tests * consolidate and clean up a bit * forgot the end * Add new test * Move test to the right spot and try agian * clean up the test * use described_class instead and clean up the chewy fields a bit * What happens if you change your discoverable attribute * lint * rename the file * Just trying to make the build happy again... * it helps when you know what your methods are called * add an if here cause it seems a bit smarter * too many blank lines... * Seperate out into more than a single file * Make the public index really public * Add some new lines... * Try to dumb down the tests again so that I can get them to pass.... * gosh so many rules * annoying contrdictory rules...make a new method * I don't think this was working correctly * Add one more test and then I think I duplicated everything that I need to before adding any new tests (if I am doing that...) and actually implementing the search part of this * Update the public status importer * Try to do a better join...not sure that I really know what I'm doing at this point * Get this working. see if we can make it better... * Okay. I think this is the best I am going to do * add some new tests for the workers * Lint the tests and the files with them... * I think this is actually more correct * Add new test file for the new concern * lint * We need to override the chewy's strategy's callback so that if we have a status also try to write it to the public status. The chewy index will take care of the rest for us and figure out what should actually happen * Single quotes * Update the index the right way * Get searching working...I think * I think this is a more correct query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on a second pass at adding better search for public + discoverable posts.
This is coming after these two reverts: