Fix: not compressing trailing zeros in IPv6 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in function findLongestZeroSequence, which has ignored trailing zeros sequences
Sebmaster
approved these changes
Jan 11, 2017
|
We need tests... our contribution documentation isn't too helpful there unfortunately. |
|
Ah right. @rmisev Can you contribute a test for this to web-platform-tests? |
|
Alternately our to-upstream directory should work and we can do the upstreaming for you later. Documentation is not great though as I said. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 12, 2017
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 12, 2017
|
Thanks so much @rmisev! BTW I didn't realize until now you were the person who helped spot the IPv6 problems in the spec; kudos for that too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in function
findLongestZeroSequence, which has ignored trailing zeros sequences.URL to test isssue:
http://[1:0::]url.hostin original version returns[1:0:0:0:0:0:0:0], but must return:[1::]