Do not processing non-browsing-context-connected <style>s

Fixes #2553. The spec actually does not cover this; see spec issue at whatwg/html#4547.
jsdom · Apr 21, 2019 · 118dca5 · 118dca5
1 parent 4285e70
commit 118dca5
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/lib/jsdom/living/nodes/HTMLStyleElement-impl.js b/lib/jsdom/living/nodes/HTMLStyleElement-impl.js
@@ -51,7 +51,8 @@ class HTMLStyleElementImpl extends HTMLElementImpl {
       removeStylesheet(this.sheet, this);
     }
 
-    if (!this._attached) {
+    // Browsing-context connected, per https://github.com/whatwg/html/issues/4547
+    if (!this.isConnected || !this._ownerDocument._defaultView) {
       return;
     }
 

diff --git a/...s/to-upstream/html/semantics/document-metadata/the-style-element/no-browsing-context.html b/...s/to-upstream/html/semantics/document-metadata/the-style-element/no-browsing-context.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>Style should not apply with no browsing context</title>
+<!-- https://github.com/whatwg/html/issues/4547 -->
+
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+
+<script>
+"use strict";
+test(() => {
+  const doc = document.implementation.createHTMLDocument();
+  const style = document.createElement("style");
+  style.textContent = `
+    p { color: red; }
+  `;
+
+  doc.head.appendChild(style);
+  doc.body.appendChild(doc.createElement("p"));
+
+  // https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue last step falls back to empty string
+  assert_equals(window.getComputedStyle(doc.querySelector("p")).color, "");
+}, "no impact on getComputedStyle");
+
+async_test(t => {
+  const doc = document.implementation.createHTMLDocument();
+  const style = document.createElement("style");
+  style.textContent = `
+    @import url('https://fonts.googleapis.com/css?family=Poppins:200,300,800');
+  `;
+
+  style.onload = t.unreached_func("load event must not be fired");
+  style.onerror = t.unreached_func("error event must not be fired");
+  doc.head.appendChild(style);
+
+  t.step_timeout(() => t.done(), 200);
+}, "no load or error events");
+</script>