Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerender htmlview when text component props is changed #188

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Rerender htmlview when text component props is changed #188

merged 3 commits into from
Jan 9, 2018

Conversation

alphasp
Copy link
Contributor

@alphasp alphasp commented Dec 19, 2017

Fix #183, based from solution from #183 (comment)

@bas-ie
Copy link
Collaborator

bas-ie commented Jan 7, 2018

Hi 😄 looks fine, please ensure the linter/tests are passing. Cheers!

@alphasp
Copy link
Contributor Author

alphasp commented Jan 8, 2018

@richchurcher updated PR, passed ci build

@bas-ie bas-ie merged commit c808625 into jsdf:master Jan 9, 2018
@bas-ie
Copy link
Collaborator

bas-ie commented Jan 9, 2018

Thanks!

@alphasp alphasp deleted the fix-text-component-props branch February 8, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphasp @bas-ie