Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work in production build #7

Open
Wykks opened this issue Jan 22, 2018 · 5 comments
Open

Does not work in production build #7

Wykks opened this issue Jan 22, 2018 · 5 comments

Comments

@Wykks
Copy link
Contributor

Wykks commented Jan 22, 2018 •
edited
Loading

Using angular/cli (v1.6.5) with --prod flag, takeUntilDestroy silently do nothing.
This is a important issue, nobody should use this until it's solved :(
@jsdevtom
Copy link
Owner

Will look in to it ASAP

@Wykks
Copy link
Contributor Author

Wykks commented Jan 22, 2018 •
edited
Loading

Only Destroyable decorator is affected. Works fine when ngOnDestroy is implemented.
Must be something caused by tsickle

@jsdevtom
Copy link
Owner

jsdevtom commented Jan 22, 2018 •
edited
Loading

I can confirm this is an issue with the tsickle itself: angular/angular-cli#2799

Here is a simple reproduction in stackblitz

@jsdevtom
Copy link
Owner

@Wykks I am trying to find a work around now

@jsdevtom
Copy link
Owner

I have updated the readme with your info #7 (comment). This could be a possible sollution: angular/angular-cli#9306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wykks @jsdevtom