Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to catch cjs compilation errors #231

Closed
jimaek opened this issue Nov 10, 2022 · 1 comment
Closed

Update tests to catch cjs compilation errors #231

jimaek opened this issue Nov 10, 2022 · 1 comment
Assignees
@MartinKolarik
Labels
high priority

Comments

@jimaek
Copy link
Member

jimaek commented Nov 10, 2022

#230
@alexey-yarmosh
Copy link
Member

That is related to error prone ts compilation of .cjs files. More info here:
microsoft/TypeScript#50647

Probably we can add a simple test to verify that compiled code is able to run.
Also, we should consider options to overcome the issues ourselves, so we are not stuck on ts v4.7.

MartinKolarik added a commit that referenced this issue Apr 17, 2023
@MartinKolarik
test: add dist test (closes ##231)
9cce719
@MartinKolarik MartinKolarik mentioned this issue Apr 17, 2023
Merged
@MartinKolarik MartinKolarik mentioned this issue May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinKolarik MartinKolarik

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimaek @MartinKolarik @alexey-yarmosh