Fixes #38
Open
Fixes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not a full fix It's just a hack for one Segment and one Cluster videos. For full fix we need to (for Segment and Cluster) rewrite element.end to waiting for next element to be next Segment(0x18538067) or Cluster(0x1F43B675)
|
I checked and it works with multiple clusters video. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are two fixes which allows demuxer to demux more .webm files
Here are fixes:
Fix
unknownIDs wasn't skipped in a few situations so demuxer lost order of bytesFix Element(Segment and Cluster) size unknown error.
Since https://w3c.github.io/mse-byte-stream-format-webm/#webm-init-segments
ClusterandSegmentcan haveundefinedsize.It is not a full fix It's just a hack for videos which have one
Segmentand oneCluster. For full fix we need to rewritethis.dataInterface.offset < this.endto waiting for next element to be nextSegment(0x18538067)orCluster(0x1F43B675)