Fix warnings

src/algs/ags/solver.cc

@@ -32,8 +32,8 @@ namespace
                       const std::vector<double>& leftBound, const std::vector<double>& rightBound)
       {
         mFunctions = functions;
-        mConstraintsNumber = mFunctions.size() - 1;
-        mDimension = leftBound.size();
+        mConstraintsNumber = static_cast<unsigned int>(mFunctions.size() - 1);
+        mDimension = static_cast<unsigned int>(leftBound.size());
         mLeftBound = leftBound;
         mRightBound = rightBound;
       }

src/algs/bobyqa/bobyqa.c

@@ -1979,12 +1979,12 @@ static nlopt_result bobyqb_(int *n, int *npt, double *x,
     int ksav;
     double gqsq, dist, sumw, sumz, diffa, diffb, diffc = 0.0, hdiag;
     int kbase;
-    double alpha, delta, adelt, denom, fsave, bdtol, delsq;
+    double alpha = 0.0, delta, adelt = 0.0, denom, fsave, bdtol, delsq;
     int nresc, nfsav;
-    double ratio, dnorm, vquad, pqold, tenth;
+    double ratio = 0.0, dnorm, vquad, pqold, tenth;
     int itest;
     double sumpq, scaden;
-    double errbig, cauchy, fracsq, biglsq, densav;
+    double errbig, cauchy = 0.0, fracsq, biglsq, densav;
     double bdtest;
     double crvmin, frhosq;
     double distsq;

src/algs/cdirect/cdirect.c

@@ -579,7 +579,7 @@ nlopt_result cdirect(int n, nlopt_func f, void *f_data,
      int i;
 
      d.f = f; d.f_data = f_data; d.lb = lb; d.ub = ub;
-     d.x = (double *) malloc(sizeof(double) * n * (stop->xtol_abs ? 4 : 3));
+     d.x = (double *) calloc(n * (stop->xtol_abs ? 4 : 3), sizeof(double));
      if (!d.x) return NLOPT_OUT_OF_MEMORY;
 
      for (i = 0; i < n; ++i) {

src/algs/cdirect/hybrid.c

@@ -320,7 +320,7 @@ nlopt_result cdirect_hybrid(int n, nlopt_func f, void *f_data,
      int i;
 
      d.f = f; d.f_data = f_data; d.lb = lb; d.ub = ub;
-     d.x = (double *) malloc(sizeof(double) * n * (stop->xtol_abs ? 4 : 3));
+     d.x = (double *) calloc(n * (stop->xtol_abs ? 4 : 3), sizeof(double));
      if (!d.x) return NLOPT_OUT_OF_MEMORY;
 
      for (i = 0; i < n; ++i) {

src/algs/crs/crs.c

@@ -52,7 +52,7 @@ static int crs_compare(double *k1, double *k2)
 {
      if (*k1 < *k2) return -1;
      if (*k1 > *k2) return +1;
-     return k1 - k2; /* tie-breaker */
+     return (int)(k1 - k2); /* tie-breaker */
 }
 
 /* set x to a random trial value, as defined by CRS:
@@ -67,7 +67,7 @@ static void random_trial(crs_data *d, double *x, rb_node *best)
 
      /* initialize x to x_0 = best point */
      memcpy(x, best->k + 1, sizeof(double) * n);
-     i0 = (best->k - ps) / n1;
+     i0 = (int)((best->k - ps) / n1);
 
      jn = nlopt_iurand(n); /* which of remaining n points is "x_n",
 			      i.e. which to reflect through ...

src/algs/neldermead/nldrmd.c

@@ -39,7 +39,7 @@ static int simplex_compare(double *k1, double *k2)
 {
      if (*k1 < *k2) return -1;
      if (*k1 > *k2) return +1;
-     return k1 - k2; /* tie-breaker */
+     return (int)(k1 - k2); /* tie-breaker */
 }
 
 /* return 1 if a and b are approximately equal relative to floating-point
@@ -202,7 +202,10 @@ nlopt_result nldrmd_minimize_(int n, nlopt_func f, void *f_data,
 	  for (i = 0; i < n; ++i) c[i] *= ninv;
 
 	  /* x convergence check: find xcur = max radius from centroid */
-	  memset(xcur, 0, sizeof(double)*n);
+		if (n > 0)
+		{
+	    memset(xcur, 0, sizeof(double)*n);
+		}
 	  for (i = 0; i < n + 1; ++i) {
                double *xi = pts + i*(n+1) + 1;
 	       for (j = 0; j < n; ++j) {

src/algs/slsqp/slsqp.c

@@ -1249,7 +1249,7 @@ static void lsq_(int *m, int *meq, int *n, int *nl,
 	     im, ip, iu, iw;
     double diag;
     int mineq;
-    double xnorm;
+    double xnorm = 0.0;
 
 /*   MINIMIZE with respect to X */
 /*             ||E*X - F|| */

src/algs/stogo/tools.cc

@@ -161,9 +161,9 @@ bool TBox::CloseToMin(RVector &vec, double *objval, double eps_cl) {
   return FALSE;
 }
 
-unsigned int TBox::NStationary() {
+int TBox::NStationary() {
   // Returns the number of trials in a box
-  return TList.size() ;
+  return static_cast<int>(TList.size());
 }
 
 void TBox::split(RTBox B1, RTBox B2) {
@@ -176,7 +176,7 @@ void TBox::split(RTBox B1, RTBox B2) {
   B1.lb=lb; B1.ub=ub;
   B2.lb=lb; B2.ub=ub;
   w=LongestSide(&i);
-  ns=TList.size();
+  ns = static_cast<int>(TList.size());
   switch (ns) {
   case 0: case 1:
     // Bisection

src/algs/stogo/tools.h

@@ -102,7 +102,7 @@ class TBox: public VBox {
   void ClearBox();            
   bool CloseToMin(RVector&, double*, double);
 
-  unsigned int NStationary();      // Returns the number of stationary points
+  int NStationary();      // Returns the number of stationary points
 
   void split(RTBox, RTBox);     // Split a box
   void dispTrials();

src/api/nlopt-in.hpp

@@ -424,7 +424,7 @@ namespace nlopt {
       d->mf     = mf;
       d->f_data = f_data;
 
-      mythrow(nlopt_add_inequality_mconstraint(o, tol.size(), mymfunc, d,
+      mythrow(nlopt_add_inequality_mconstraint(o, static_cast<unsigned int>(tol.size()), mymfunc, d,
 					       tol.empty() ? NULL : &tol[0]));
     }
 
@@ -453,7 +453,7 @@ namespace nlopt {
       d->mf     = mf;
       d->f_data = f_data;
 
-      mythrow(nlopt_add_equality_mconstraint(o, tol.size(), mymfunc, d,
+      mythrow(nlopt_add_equality_mconstraint(o, static_cast<unsigned int>(tol.size()), mymfunc, d,
 					     tol.empty() ? NULL : &tol[0]));
     }
 
@@ -489,7 +489,7 @@ namespace nlopt {
       d->munge_destroy = md;
       d->munge_copy    = mc;
 
-      mythrow(nlopt_add_inequality_mconstraint(o, tol.size(), mymfunc, d,
+      mythrow(nlopt_add_inequality_mconstraint(o, static_cast<unsigned int>(tol.size()), mymfunc, d,
 					       tol.empty() ? NULL : &tol[0]));
     }
     void add_equality_mconstraint(mfunc mf, void *f_data,
@@ -501,7 +501,7 @@ namespace nlopt {
       d->munge_destroy = md;
       d->munge_copy    = mc;
 
-      mythrow(nlopt_add_equality_mconstraint(o, tol.size(), mymfunc, d,
+      mythrow(nlopt_add_equality_mconstraint(o, static_cast<unsigned int>(tol.size()), mymfunc, d,
 					     tol.empty() ? NULL : &tol[0]));
     }
 

src/api/optimize.c

@@ -394,7 +394,7 @@ static int elimdim_wrapcheck(nlopt_opt opt)
 
 /*********************************************************************/
 
-#define POP(defaultpop) (opt->stochastic_population > 0 ? opt->stochastic_population : (nlopt_stochastic_population > 0 ? nlopt_stochastic_population : (defaultpop)))
+#define POP(defaultpop) (opt->stochastic_population > 0 ? (int)opt->stochastic_population : (nlopt_stochastic_population > 0 ? nlopt_stochastic_population : (defaultpop)))
 
 /* unlike nlopt_optimize() below, only handles minimization case */
 static nlopt_result nlopt_optimize_(nlopt_opt opt, double *x, double *minf)
@@ -532,7 +532,7 @@ static nlopt_result nlopt_optimize_(nlopt_opt opt, double *x, double *minf)
 #ifdef NLOPT_CXX
         if (!finite_domain(n, lb, ub))
             RETURN_ERR(NLOPT_INVALID_ARGS, opt, "finite domain required for global algorithm");
-        if (!stogo_minimize(ni, f, f_data, x, minf, lb, ub, &stop, algorithm == NLOPT_GD_STOGO ? 0 : (int) POP(2 * n)))
+        if (!stogo_minimize(ni, f, f_data, x, minf, lb, ub, &stop, algorithm == NLOPT_GD_STOGO ? 0 : POP(2 * (int)n)))
             return NLOPT_FAILURE;
         break;
 #else
@@ -605,7 +605,7 @@ static nlopt_result nlopt_optimize_(nlopt_opt opt, double *x, double *minf)
     case NLOPT_GN_CRS2_LM:
         if (!finite_domain(n, lb, ub))
             RETURN_ERR(NLOPT_INVALID_ARGS, opt, "finite domain required for global algorithm");
-        return crs_minimize(ni, f, f_data, lb, ub, x, minf, &stop, (int) POP(0), 0);
+        return crs_minimize(ni, f, f_data, lb, ub, x, minf, &stop, POP(0), 0);
 
     case NLOPT_G_MLSL:
     case NLOPT_G_MLSL_LDS:
@@ -646,7 +646,7 @@ static nlopt_result nlopt_optimize_(nlopt_opt opt, double *x, double *minf)
                 nlopt_set_xtol_rel(local_opt, 1e-7);
             }
             push_force_stop_child(opt, local_opt);
-            ret = mlsl_minimize(ni, f, f_data, lb, ub, x, minf, &stop, local_opt, (int) POP(0), algorithm >= NLOPT_GN_MLSL_LDS && algorithm != NLOPT_G_MLSL);
+            ret = mlsl_minimize(ni, f, f_data, lb, ub, x, minf, &stop, local_opt, POP(0), algorithm >= NLOPT_GN_MLSL_LDS && algorithm != NLOPT_G_MLSL);
             pop_force_stop_child(opt);
             if (!opt->local_opt)
                 nlopt_destroy(local_opt);
@@ -675,7 +675,7 @@ static nlopt_result nlopt_optimize_(nlopt_opt opt, double *x, double *minf)
             nlopt_set_ftol_abs(dual_opt, nlopt_get_param(opt, "dual_ftol_abs", LO(ftol_abs, 0.0)));
             nlopt_set_xtol_rel(dual_opt, nlopt_get_param(opt, "dual_xtol_rel", 0.0));
             nlopt_set_xtol_abs1(dual_opt, nlopt_get_param(opt, "dual_xtol_abs", 0.0));
-            nlopt_set_maxeval(dual_opt, nlopt_get_param(opt, "dual_maxeval", LO(maxeval, 100000)));
+            nlopt_set_maxeval(dual_opt, (int)nlopt_get_param(opt, "dual_maxeval", LO(maxeval, 100000)));
 #undef LO
             if (algorithm == NLOPT_LD_MMA)
                 ret = mma_minimize(n, f, f_data, opt->m, opt->fc, lb, ub, x, minf, &stop, dual_opt, inner_maxeval, (unsigned)verbosity, rho_init, opt->dx);
@@ -793,7 +793,7 @@ static nlopt_result nlopt_optimize_(nlopt_opt opt, double *x, double *minf)
     case NLOPT_GN_ISRES:
         if (!finite_domain(n, lb, ub))
             RETURN_ERR(NLOPT_INVALID_ARGS, opt, "finite domain required for global algorithm");
-        return isres_minimize(ni, f, f_data, (int) (opt->m), opt->fc, (int) (opt->p), opt->h, lb, ub, x, minf, &stop, (int) POP(0));
+        return isres_minimize(ni, f, f_data, (int) (opt->m), opt->fc, (int) (opt->p), opt->h, lb, ub, x, minf, &stop, POP(0));
 
     case NLOPT_GN_ESCH:
         if (!finite_domain(n, lb, ub))

src/swig/nlopt-python.i

@@ -124,8 +124,10 @@ __version__ = str(_nlopt.version_major())+'.'+str(_nlopt.version_minor())+'.'+st
 {
   npy_intp sz = $1.size();
   $result = PyArray_SimpleNew(1, &sz, NPY_DOUBLE);
-  std::memcpy(array_data($result), $1.empty() ? NULL : &$1[0],
-	      sizeof(double) * sz);
+  if (!$1.empty())
+  {
+    std::memcpy(array_data($result), &$1[0], sizeof(double) * sz);
+  }
 }
 
 //////////////////////////////////////////////////////////////////////////////

src/util/timer.c

@@ -51,7 +51,7 @@ double nlopt_seconds(void)
     gettimeofday(&tv, NULL);
     return (tv.tv_sec - start.tv_sec) + 1.e-6 * (tv.tv_usec - start.tv_usec);
 #elif defined(HAVE_TIME)
-    return time(NULL);
+    return (double)time(NULL);
 #elif defined(_WIN32) || defined(__WIN32__)
     static THREADLOCAL ULONGLONG start;
     FILETIME ft;
@@ -82,7 +82,7 @@ unsigned long nlopt_time_seed(void)
     gettimeofday(&tv, NULL);
     return (tv.tv_sec ^ tv.tv_usec);
 #elif defined(HAVE_TIME)
-    return time(NULL);
+    return (unsigned long)time(NULL);
 #elif defined(_WIN32) || defined(__WIN32__)
     FILETIME ft;
     GetSystemTimeAsFileTime(&ft);

test/cpp_functor.cxx

@@ -100,7 +100,7 @@ class LinearRegression {
     LinearRegression(QuadraticForm quadratic_form_) :
       quadratic_form(std::move(quadratic_form_)) {}
 
-    double operator()(unsigned n, const double* x, double* grad) const
+    double operator()(unsigned /*n*/, const double* x, double* grad) const
     {
       const double result = quadratic_form.compute_form(x);
       if (!!grad) {