Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for files with size more than buffer size #197

Closed
wants to merge 1 commit into from
Closed

fix for files with size more than buffer size #197

wants to merge 1 commit into from

Conversation

vinayinvicible
Copy link
Contributor

fixes #160

@codecov-io
Copy link

codecov-io commented Sep 2, 2016

Codecov Report

Merging #197 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   75.32%   75.48%   +0.15%     
==========================================
  Files          11       11              
  Lines        1552     1558       +6     
==========================================
+ Hits         1169     1176       +7     
+ Misses        383      382       -1
Impacted Files Coverage Δ
storages/backends/s3boto.py 88.13% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcdf9e...4cc8e35. Read the comment docs.

@vinayinvicible
Copy link
Contributor Author

@jschneier can you take a look at this

@vinayinvicible
Copy link
Contributor Author

@jschneier

@jschneier
Copy link
Owner

Thanks, will look at this today.

@vinayinvicible
Copy link
Contributor Author

@jschneier
any updates on this.

@jsh2134
Copy link

jsh2134 commented Sep 25, 2017

can this same change be ported to s3boto3.py ?

I now see #364 and it's fix #365

gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
gomlgs added a commit to gomlgs/django-storages that referenced this pull request Mar 20, 2018
jnm added a commit to jnm/django-storages that referenced this pull request May 30, 2018
@jschneier
Copy link
Owner

Consolidated and fixed in #504.

@jschneier jschneier closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with S3BotoStorageFile and a file greater than 5Mb
4 participants