Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload files > 5 gb with S3BotoStorage class? #194

Closed
pacahon opened this issue Aug 27, 2016 · 6 comments
Closed

Upload files > 5 gb with S3BotoStorage class? #194

pacahon opened this issue Aug 27, 2016 · 6 comments
Labels

Comments

@pacahon
Copy link

pacahon commented Aug 27, 2016

Hello. Is it possible to upload files > 5gb (and less < 50 gb) to s3 storage in multipart mode? I can see something related in S3BotoStorageFile class, but looks like it's not used in _save method, only set_contents_from_file which try to upload the whole file as I guess.

@ZuluPro
Copy link
Contributor

ZuluPro commented Sep 1, 2016

@pacahon : Sorry for the latency, I must look deeper before help you

@pacahon
Copy link
Author

pacahon commented Sep 1, 2016

@ZuluPro I hope that the answer boto/boto3#789
Looks like we can replace put method with upload_fileojb. Will test it ASAP.

@ZuluPro
Copy link
Contributor

ZuluPro commented Sep 1, 2016

@pacahon I think we're going to remove boto3 from django-storages.
Boto is compatible with Python 3, so no need to maintains a second almost similar backend.

@pacahon
Copy link
Author

pacahon commented Sep 1, 2016

@ZuluPro Boto3, the next version of Boto, is now stable and recommended for general use. Maybe remove boto? :)

@mbarrien
Copy link
Contributor

mbarrien commented Sep 1, 2016

@ZuluPro once again, as Boto maintainers themselves say, Boto is effectively deprecated for Boto 3. http://boto.readthedocs.io/en/latest/ says this multiple times on the page:

"Note Boto3, the next version of Boto, is now stable and recommended for general use. It can be used side-by-side with Boto in the same project, so it is easy to start using Boto3 in your existing projects as well as new projects. Going forward, API updates and all new feature work will be focused on Boto3."

Notice the last sentence. Boto 2 is effectively dead. Removing Boto3 support in favor of something that has been stated by the maintainers to be dead is not the wisest move.

btoueg added a commit to Mobeye/django-storages that referenced this issue Sep 13, 2016
@jschneier
Copy link
Owner

We are definitely going to keep both. Boto3 is the future but tons and tons of projects rely on the old Boto backend. I'm just going to WONT-FIX boto issues that are pains in the future and point them at Boto3.

jschneier pushed a commit that referenced this issue Sep 13, 2016
* Add support for files > 5 gb with S3BotoStorage

Fixes #194

* Fix tests
jschneier added a commit that referenced this issue Sep 13, 2016
snowlotus530 pushed a commit to snowlotus530/storages_django that referenced this issue Oct 3, 2021
* Add support for files > 5 gb with S3BotoStorage

Fixes jschneier/django-storages#194

* Fix tests
ipyramiddev added a commit to ipyramiddev/storage-api-django that referenced this issue Mar 22, 2023
* Add support for files > 5 gb with S3BotoStorage

Fixes jschneier/django-storages#194

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants