Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tb.remove #58

Closed
jscastro76 opened this issue Oct 25, 2020 · 0 comments
Closed

Refactor tb.remove #58

jscastro76 opened this issue Oct 25, 2020 · 0 comments
Assignees
Milestone

Comments

@jscastro76
Copy link
Owner

Describe the issue
tb.remove is not disposing the objects properly, .geometry, .material and its subsequent .material.map, .material.alphaMap... are not disposed.

@jscastro76 jscastro76 added this to the v2.0.6. milestone Oct 25, 2020
@jscastro76 jscastro76 self-assigned this Oct 25, 2020
jscastro76 added a commit that referenced this issue Oct 25, 2020
…e 3D objects of a layer, apart from removing the layer itself with `map.removeLayer`

- [**#56**](#56) Objects cache at `tb.loadObj`
  - `tb.loadObj` now is 100% async and in the first call to an object load by url, then caches the returned object for the sucessive calls to return a clone of the object through `obj.duplicate()`
  - Closes [**#51**](#51), [**#55**](#55)
- [**#57**](#57) Add a new sample to measure performance
  - Added new example to demonstrate add thousands of objects and measure performance [Threebox Performance](https://github.com/jscastro76/threebox/blob/master/examples/15-performance.html).
- [**#58**](#58) Refactor `tb.remove`
- [**#59**](#59) Refactor `tb.clear` to add `layerId`.
- [**#60**](#58) Refactor `tb.dispose`
- All the examples reviewed and updated and added to the [Examples list](https://github.com/jscastro76/threebox/blob/master/examples/readme.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant