Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dat.gui.module has changed in threejs #319

Closed
jscastro76 opened this issue Jan 10, 2022 · 0 comments
Closed

dat.gui.module has changed in threejs #319

jscastro76 opened this issue Jan 10, 2022 · 0 comments
Assignees
@jscastro76
Labels
🪲 bug Something isn't working
Milestone
v.2.2.6.

Comments

@jscastro76
Copy link
Owner

Detected by @janhaa dat.gui.module has disappeared from three.js, so it must be replaced by

import { GUI } from 'https://threejs.org/examples/jsm/libs/lil-gui.module.min.js';

So all the examples using it ( 8, 9, 15, 19, 20) are returning a 404 error.
@jscastro76 jscastro76 added the 🪲 bug Something isn't working label Jan 10, 2022
@jscastro76 jscastro76 added this to the v.2.2.6. milestone Jan 10, 2022
@jscastro76 jscastro76 self-assigned this Jan 10, 2022
jscastro76 added a commit that referenced this issue Jan 10, 2022
@jscastro76
## 2.2.6
1a85f78 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #310 extrusion.materials null by default, but not labelled as 'required' in documentation
  - THREE.MeshPhongMaterial({ color: 0x660000, side: THREE.DoubleSide }) added as default material to extrusions

#### 🪲 Bug fixes
- #319 dat.gui.module has changed in threejs
- #320 Cannot read properties of undefined (reading 'appendChild')

#### 📝 Documentation
- Updated [Threebox documentation](/docs/Threebox.md) (`tb.extrusion` param `materials`)
@jscastro76 jscastro76 mentioned this issue Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
v.2.2.6.
Development

No branches or pull requests
1 participant
@jscastro76