Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KNOWN ISSUE: Create a warning for sky layers when used with Mapbox < 2.0 #242

Closed
jscastro76 opened this issue May 2, 2021 · 0 comments
Closed

KNOWN ISSUE: Create a warning for sky layers when used with Mapbox < 2.0 #242

jscastro76 opened this issue May 2, 2021 · 0 comments
Assignees
@jscastro76
Labels
🪲 bug Something isn't working
Milestone
v2.2.3.

Comments

@jscastro76
Copy link
Owner

Describe the bug
When sky: true is part of Threebox init params and mapbox < 2.0 this error is raised

Error: layers.sky-layer: missing required property "source"
    at Object.bn [as emitValidationErrors] (util.js:122)
    at Oe (index.js:133)
    at i._validate (index.js:133)
    at i.addLayer (index.js:133)
    at r.addLayer (index.js:133)
    at Threebox.createSkyLayer (threebox.js:865)
    at r.<anonymous> (threebox.js:383)
    at r.Tt.fire (util.js:122)
    at i.Tt.fire (util.js:122)
    at i._load (index.js:133)

Expected behavior
This should be controlled by Threebox with a warning

  • Version 2.2.2
@jscastro76 jscastro76 added the 🪲 bug Something isn't working label May 2, 2021
@jscastro76 jscastro76 self-assigned this May 7, 2021
@jscastro76 jscastro76 added this to the v2.2.3. milestone May 7, 2021
jscastro76 added a commit that referenced this issue May 8, 2021
@jscastro76
## 2.2.3
8729407 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #243 Create a new example on terrain layer
  - New example on terrain layer with a 3D model aligned vertically [21-terrain.html](https://github.com/jscastro76/threebox/blob/master/examples/21-terrain.html)
- #244 Darken the raster layer with realSunlight

#### 🪲 Bug fixes
- #233 map.setLight is not updated when tb.setStyle until the map moves
- #237 `ObjectMouseOver` doesn't work after triggering `SelectedChange`
- #241 KNOWN ISSUE: Terrain layer calculates wrongly the object height
- #242 KNOWN ISSUE: Create a warning for sky layers when used with Mapbox < 2.0

#### 📝 Documentation
- Updated [documentation](/examples/readme.md)
- Updated [Threebox documentation](/docs/Threebox.md) (`terrain` attribute and property, `tb.createTerrainLayer`, `tb.updateSunGround`)
- Updated [Examples](/examples) documentation (new terrain layer in 21).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
v2.2.3.
Development

No branches or pull requests
1 participant
@jscastro76