Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dasithw/otel collector #3

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Dasithw/otel collector #3

merged 6 commits into from
Nov 4, 2024

Conversation

dasiths
Copy link
Collaborator

@dasiths dasiths commented Nov 2, 2024

This PR instruments the backend with OpenTelemetry and sets up a OpenTelemetry collector pipeline with Grafana LGTM.

The official OpenAI OTEL SDK hasn't been released yet. open-telemetry/opentelemetry-python-contrib#2759

@dasiths dasiths requested a review from jsburckhardt November 2, 2024 15:24
Copy link
Owner

@jsburckhardt jsburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makign sense - left minor comments

opentelemetry-exporter-otlp==1.27.0
opentelemetry-instrumentation-requests==0.48b0
opentelemetry-instrumentation-httpx==0.48b0
opentelemetry-instrumentation-openai==0.33.5 # this is the traceloop one https://github.com/traceloop/openllmetry/tree/main/packages/opentelemetry-instrumentation-openai/opentelemetry/instrumentation/openai
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we be using the official openai one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we need them to run the app - shall we add them to the devcontainer - so the dc goes in a compose file?

@jsburckhardt jsburckhardt merged commit 6861e94 into main Nov 4, 2024
@jsburckhardt jsburckhardt deleted the dasithw/otel-collector branch November 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants