Add esplora plugin from lvaccaro

[jsarenik]

https://github.com/lightningamp/esplora_clnd_plugin

[jsarenik]

The force-push history will be tracked in this fake PR. So far my local reflog says this:

$ git reflog | grep esplora
70977a4fb HEAD@{0}: checkout: moving from jsn/esplora to master
33f2863b8 HEAD@{1}: commit (amend): Add esplora plugin from lvaccaro
5312d5ff7 HEAD@{2}: rebase finished: returning to refs/heads/jsn/esplora
5312d5ff7 HEAD@{3}: rebase: Add esplora plugin from lvaccaro
c5a8d615d HEAD@{5}: checkout: moving from master to jsn/esplora
ff090ecfe HEAD@{7}: checkout: moving from jsn/esplora to master
c5a8d615d HEAD@{8}: rebase finished: returning to refs/heads/jsn/esplora
c5a8d615d HEAD@{9}: rebase: Add esplora plugin from lvaccaro
5398d2ded HEAD@{11}: checkout: moving from master to jsn/esplora
66b2bb9a9 HEAD@{13}: checkout: moving from jsn/esplora to master
5398d2ded HEAD@{14}: commit: Add esplora plugin from lvaccaro
66b2bb9a9 HEAD@{15}: checkout: moving from master to jsn/esplora

[jsarenik]

The steps I use to update this branch are:

cd ~/src/lightning
git checkout master
git pull
git push jsn
git checkout jsn/esplora
git rebase master
git push --force jsn

[jsarenik]

The tests are currently broken by this:

lightningd-1: 2020-12-13T16:57:49.946Z **BROKEN** plugin-esplora: Plugin marked as important, shutting down lightningd!

[jsarenik]

It corrently throws a compilation error:

plugins/esplora.c: In function ‘main’:
plugins/esplora.c:776:12: error: passing argument 2 of ‘plugin_main’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  776 |      argv, init, PLUGIN_STATIC, false, NULL, commands,
      |            ^~~~
      |            |
      |            void (*)(struct plugin *, const char *, const jsmntok_t *) {aka void (*)(struct plugin *, const char *, const struct <anonymous> *)}
In file included from plugins/esplora.c:22:
./plugins/libplugin.h:280:20: note: expected ‘const char * (*)(struct plugin *, const char *, const jsmntok_t *)’ {aka ‘const char * (*)(struct plugin *, const char *, const struct <anonymous> *)’} but argument is of type ‘void (*)(struct plugin *, const char *, const jsmntok_t *)’ {aka ‘void (*)(struct plugin *, const char *, const struct <anonymous> *)’}
  280 |      const char *(*init)(struct plugin *p,
      |      ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
  281 |            const char *buf,
      |            ~~~~~~~~~~~~~~~~
  282 |            const jsmntok_t *),
      |            ~~~~~~~~~~~~~~~~~~

[jsarenik]

Compilation error fixed:

diff --git a/plugins/esplora.c b/plugins/esplora.c
index 2657c345e..6ab1fb27b 100644
--- a/plugins/esplora.c
+++ b/plugins/esplora.c
@@ -671,7 +671,7 @@ static bool configure_esplora_with_network(const char *network,
 	return false;
 }
 
-static void init(struct plugin *p, const char *buffer, const jsmntok_t *config)
+static const char *init(struct plugin *p, const char *buffer, const jsmntok_t *config)
 {
 	const jsmntok_t *proxy_tok = json_get_member(buffer, config, "proxy");
 	if (proxy_tok) {
@@ -719,6 +719,7 @@ static void init(struct plugin *p, const char *buffer, const jsmntok_t *config)
 	if (proxy_conf->proxy_enabled && !esplora->proxy_disabled)
 		plugin_log(p, LOG_INFORM, "proxy configuration %s:%d",
 			   proxy_conf->address, proxy_conf->port);
+	return NULL;
 }
 
 static struct esplora *new_esplora(const tal_t *ctx)

[jsarenik]

@vincenzopalazzo FYI ^^ (see above)

[vincenzopalazzo]

@jsarenik hello, I will take a look to compile it in my dev environment and I will return back here when I have some feedback at the moment it looks good. What do you think @lvaccaro?

Update: I missed this update inside the lightning ElementsProject@27c006f.

ack 157b4c4

[jsarenik]

Now that I finally have a simple script I am thinking about discontinuing this branch. What do you think @lvaccaro and @vincenzopalazzo? Thank you!

[vincenzopalazzo]

@jsarenik concept ack for the script. It looks good to me, and I will test it on my local machine soon.

I am thinking about discontinuing this branch

This is up to you :)