Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crnn-mri #5

Merged
merged 10 commits into from
Jan 21, 2019
Merged

Crnn-mri #5

merged 10 commits into from
Jan 21, 2019

Conversation

cq615
Copy link
Collaborator

@cq615 cq615 commented Jan 19, 2019

Added pytorch implementation for CRNN-MRI.

main_crnn.py Outdated Show resolved Hide resolved
main_crnn.py Outdated Show resolved Hide resolved
cascadenet/util/dnn_io.py Outdated Show resolved Hide resolved
cascadenet/util/dnn_io.py Outdated Show resolved Hide resolved
cascadenet/util/dnn_io.py Outdated Show resolved Hide resolved
main_crnn.py Outdated Show resolved Hide resolved
@js3611
Copy link
Owner

js3611 commented Jan 19, 2019

Address the minor comments and should be good

@js3611
Copy link
Owner

js3611 commented Jan 19, 2019

We should keep theano+lasagne and pytorch separated, so people don't need to install old libraries anymore. If you could make cascadenet_pytorch module and put all the new code in here, that would be great! Keep main_crnn.py in the main directory.

main_crnn.py Show resolved Hide resolved
main_crnn.py Show resolved Hide resolved
@js3611
Copy link
Owner

js3611 commented Jan 21, 2019

Looks good. Thanks!

@cq615 cq615 merged commit d8a40ef into master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants