-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More spec ports, and small updates to GetTemporalUnit typings. #183
Conversation
FYI that I'll be on vacation till the 6th of September (2022), so I won't respond till then. There's no rush on this review. I've asked some colleagues to take a look at some of the more complex type-system implementation I used for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also the final state of the playground I was working with while experimenting. I have a few links to earlier versions of it throughout the review (as well as a few other links to separate playgrounds, so there's that).
UPSTREAM_COMMIT=1e9ea70f694b2afc0f18a1faae64a8b3cf0604b6 Co-authored-by: James Wright <[email protected]>
@justingrant @ptomato I think Steve and I are done with back-and-forth on this, and I'd appreciate if you could take a look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I didn't deep-dive into all the changes to the typing of PrepareTemporalFields.
Separately, if it turns out that the types of PrepareTemporalFields are that convoluted, it may be worth deviating from the spec text there (in a way that's not observable from JS, of course) and having separate operations for PreparePlainDateFields, etc. if their types are easier to express. But that would be out of scope for this PR.
Like other spec port PR's, I will merge this as-is without squashing to retain history.