Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): support module.rules for webpack 2 #154

Closed
wants to merge 1 commit into from

Conversation

outsideris
Copy link

close #136

I'm not sure it's a correct way to support module.rules because it's my first time with joi.

@kentcdodds
Copy link
Collaborator

Thanks for the PR! I realize you probably put a lot of work into it. But I'm afraid you've missed an important note in the README:

Note: webpack v2 has built-in validation for configuration. Due to this, webpack-validator is unlikely to make significant changes. While pull requests will be reviewed and can be merged, project maintainers are unlikely to put a lot of much effort into the maintenance of the project.

I don't think that we'll merge your PR :-/

@outsideris
Copy link
Author

@kentcdodds Oops, I missed it. Thank you for notifying me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module.loaders is now module.rules
2 participants