Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer const over let #3

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Prefer const over let #3

merged 2 commits into from
Nov 21, 2018

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Oct 10, 2018

In order to comply with this new standard rule ☺️

standard/eslint-config-standard#133

@LinusU LinusU mentioned this pull request Oct 10, 2018
Merged
24 tasks
@LinusU
Copy link
Contributor Author

LinusU commented Nov 21, 2018

ping @jmdobry, @techniq ☺️

@crobinson42
Copy link
Member

Thanks for the PR, out of curiosity, what triggered this need for a change?

@LinusU
Copy link
Contributor Author

LinusU commented Nov 21, 2018

We want to enable the rule prefer-const in the next version of Standard, and there were a few packages that were currently breaking that rule. After this and five other PRs are merged every standard package should be compliant and we can add the rule ☺️

You can read some background discussion here: standard/standard#159 and see the pr here: standard/eslint-config-standard#133

@crobinson42 crobinson42 merged commit 89eb9f5 into js-data:master Nov 21, 2018
@LinusU LinusU deleted the prefer-const branch November 21, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinusU @crobinson42