Resolve test failure from bundler 2.2.24+ #544
Conversation
|
Just poking in to note that jruby-9.2 is pretty ancient so it failing with the new .lock file is not so surprising. This work should probably update to 9.4 (9.3 is still supported but not for too much longer). Not sure if that will start to pull the sweater apart or be relatively error-free. |
iterateNZ
force-pushed
the
bundler-2.4-support-fix
branch
2 times, most recently
from
c9c167a
to
a82ce21
Compare
|
Trying a slightly different tack and including two bundler versions in the build matrix (sneaking in jruby 9.3, 9.4 and java 11 as well). I haven't been able to get clean consistent builds of these environments locally so relying on the CI setup here to verify the changes. The bundler version running the rspec should be what is then used for the |
iterateNZ
force-pushed
the
bundler-2.4-support-fix
branch
2 times, most recently
from
0eb2f9a
to
015888b
Compare
| @@ -8,7 +8,7 @@ def self.reset_local_repository | |||
|
|
|||
| describe Warbler::WebServer::Artifact do | |||
|
|
|||
| @@_env = ENV.dup | |||
| @@_env = ENV.to_h | |||
There was a problem hiding this comment.
Should resolve test failures on jruby v9.4+
Bundler v2.2.24 changed the behaviour of `Bundler::Definition#specs_for` when the requested groups are empty from returning nothing to everything.
* TypeError: Cannot dup ENV, use ENV.to_h to get a copy of ENV as a hash * LoadError: no such file to load -- rexml/document
iterateNZ
force-pushed
the
bundler-2.4-support-fix
branch
from
015888b
to
b08df0b
Compare
|
Looks like this is passing on jruby-head now as well, that's a nice bonus. |
|
Yes! So, this looks amazing, and I think that we are ready for it! |
Bundler v2.2.24 changed the behaviour of
Bundler::Definition#specs_forwhen the requested groups are empty from returning nothing to everything.